On Tue, Aug 01, 2017 at 06:35:08PM +0800, Anand Jain wrote: > We didn't copy fsid to struct super_block.s_uuid so Overlay disables > index feature with btrfs as the lower FS. > > kernel: overlayfs: fs on '/lower' does not support file handles, falling back > to index=off. > > Fix this by publishing the fsid through struct super_block.s_uuid. > > Signed-off-by: Anand Jain <anand.j...@oracle.com> > --- > I tried to know if in case did we deliberately missed this for some reason, > however there is no information on that. If we mount a non-default subvol in > the next mount/remount, its still the same FS, so publishing the FSID > instead of subvol uuid is correct, OR I can't think any other reason for > not using s_uuid for btrfs.
I think that setting s_uuid is the last missing bit. Overlay needs the file handle encoding support from the lower filesystem, which is supported. Filling the whole filesystem id is correct, the subvolume id is encoded in the file handle buffer from inside btrfs_encode_fh. >From that point I think the patch is ok, but haven't tested it. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
