On Fri, Aug 18, 2017 at 11:42:07AM -0600, Liu Bo wrote: > We have started plug in btrfs_write_and_wait_marked_extents() but the > generated IOs actually go to device's schedule IO list where the work > is doing in another task, thus the started plug doesn't make any > sense. > > And since we wait for IOs immediately after writing meta blocks, it's > the same case as writing log tree, doing sync submit can merge more > IOs. >
We're plugging when we do the per-device scheduled IO right? So we aren't really gaining anything by it being async. Also we do a lot of work between the time that we start writing the marked extents for the tree-log and when we actually wait for them, so we really don't want to do a synchronous write out in that case. Instead move the sync_writers into write_and_wait_marked_extents. Thanks, Josef -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
