On Thu, Aug 24, 2017 at 06:19:48PM -0600, Liu Bo wrote: > This updates btrfs to use the helper wbc_to_write_flags which has been > applied in ext4/xfs/f2fs/block.
Added in commit 7637241e651ec36e4094 in 11/2016, I wonder why btrfs wasn't been changed as well as it uses the same code patterns as the other filesystems. > Please note that, with this, btrfs's dirty pages written by a > writeback job will carry the flag REQ_BACKGROUND, which is currently > used by writeback-throttle to determine whether it should go to get a > request or wait. Which in my understanding of the WBT behaviour is what we want, right? > Signed-off-by: Liu Bo <bo.li....@oracle.com> Reviewed-by: David Sterba <dste...@suse.com> I'm still expecting some surprises (== performance drop) from the recent WBT changes, as we still may miss some request flags, but more subtle than eg. the superblock REQ_ tags. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
