On Sun, Sep 24, 2017 at 05:17:19PM +0300, Nikolay Borisov wrote: > >>> However, such whac-a-mole fix will finally be a nightmare to maintain. > >>> > >>> What about integrating all of such validation checkers into one place? > >>> So fsck part will only need to check their cross reference without > >>> bothering such corruption. > >>> > >> I was confused how to fix the bug(new checker or little changes > >> in this patch). > >> The reason why I fix it in this way is that most callers do > >> check type before calling btrfs_extent_inline_ref_size(). > >> > >> Since you prefer the former, I'm going to do it. > > > > Current version looks good enough as a fix.> > > Just saying we'd better using an integrated solution later. > > I agree with you that we should have an integrated solution but frankly > I'd rather see it sooner rather than later, because history has shown > that if something is not done when it's first talked about it usually > gets bogged down by other work. With this in mind, Su, might I ask you > that you repost the patch but with the centralised idea of handling the > validation lifted from Qu's kernel side patches.
Agreed. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
