May be then just add a comment at least at one of that functions? Like: /* * Handle unaligned end, end is inclusive, so always unaligned */
Or something like: /* * It's obvious, kernel use paging, so range * Almost always have aligned start like 0 * and unaligned end like 8192 - 1 */ Or we assume that everybody who look at kernel code, must understood that basic things? Thanks 2017-10-10 19:37 GMT+03:00 David Sterba <dste...@suse.cz>: > On Tue, Oct 03, 2017 at 06:06:03PM +0300, Timofey Titovets wrote: >> At now while switch page bits in data ranges >> we always hande +1 page, for cover case >> where end of data range is not page aligned > > The 'end' is inclusive and thus not aligned in most cases, ie. it's > offset 4095 in the page, so the IS_ALIGNED is allways true and the code > is equivalent to the existing condition (index <= end_index). -- Have a nice day, Timofey. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
