2017-10-20 16:45 GMT+03:00 David Sterba <dste...@suse.cz>: > On Fri, Oct 20, 2017 at 01:48:01AM +0300, Timofey Titovets wrote: >> 2017-10-19 18:39 GMT+03:00 David Sterba <dste...@suse.cz>: >> > On Fri, Sep 29, 2017 at 06:22:00PM +0200, David Sterba wrote: >> >> On Thu, Sep 28, 2017 at 05:33:35PM +0300, Timofey Titovets wrote: >> >> > Compile tested, hand tested on live system >> >> > >> >> > Change v7 -> v8 >> >> > - All code moved to compression.c (again) >> >> > - Heuristic workspaces inmplemented another way >> >> > i.e. only share logic with compression workspaces >> >> > - Some style fixes suggested by Devid >> >> > - Move sampling function from heuristic code >> >> > (I'm afraid of big functions) >> >> > - Much more comments and explanations >> >> >> >> Thanks for the update, I went through the patches and they looked good >> >> enough to be put into for-next. I may have more comments about a few >> >> things, but nothing serious that would hinder testing. >> > >> > I did a final pass through the patches and edited comments wehre I was >> > not able to undrerstand them. Please check the updated patches in [1] if >> > I did not accidentally change the meaning. >> >> I don't see a link [1] in mail, may be you missed it? > > Yeah, sorry: > https://github.com/kdave/btrfs-devel/commits/ext/timofey/heuristic
I did re-read updated comments, looks ok to me (i only found one typo, leave a comment). Thanks -- Have a nice day, Timofey. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html