On Wed, Dec 06, 2017 at 12:15:45PM +0530, Harish wrote: > On platforms with a page size greater than 4Kb, at the moment btrfs > doesn't support a node/leaf size smaller than the page size, but it > supports a larger one. So use the max supported node size (64Kb) so > that the test runs on any platform currently supported by Linux. > > Signed-off-by: Harish <har...@linux.vnet.ibm.com>
Looks fine to me. Also cc btrfs list for review. Thanks, Eryu > --- > tests/btrfs/057 | 7 +++++-- > tests/btrfs/057.out | 4 ++-- > 2 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/tests/btrfs/057 b/tests/btrfs/057 > index 8d35579..06b2be9 100755 > --- a/tests/btrfs/057 > +++ b/tests/btrfs/057 > @@ -48,8 +48,11 @@ _require_scratch > > rm -f $seqres.full > > -# use small leaf size to get higher btree height. > -run_check _scratch_mkfs "-b 1g --nodesize 4096" > +# Currently in btrfs the node/leaf size can not be smaller than the page > +# size (but it can be greater than the page size). So use the largest > +# supported node/leaf size (64Kb) so that the test can run on any platform > +# that Linux supports. > +run_check _scratch_mkfs "-b 1g --nodesize 65536" > > # inode cache is saved in the FS tree itself for every > # individual FS tree,that affects the sizes reported by qgroup show > diff --git a/tests/btrfs/057.out b/tests/btrfs/057.out > index 60cb92d..f2d9e9c 100644 > --- a/tests/btrfs/057.out > +++ b/tests/btrfs/057.out > @@ -1,3 +1,3 @@ > QA output created by 057 > -4096 4096 > -4096 4096 > +65536 65536 > +65536 65536 > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
