On 13.12.2017 00:09, Liu Bo wrote:
> On Tue, Dec 12, 2017 at 07:52:38PM +0100, David Sterba wrote:
>> On Mon, Dec 11, 2017 at 02:57:56PM -0800, Liu Bo wrote:
>>> On Mon, Dec 11, 2017 at 04:38:48PM +0200, Nikolay Borisov wrote:
>>>> This code was added in 492bb6deee34 ("Btrfs: Hold a reference on bios
>>>> during submit_bio, add some extra bio checks"). However, holding a
>>>> reference on a bio is necessary only if it's going to be referenced
>>>> after the submit_bio returns and the bio is completed. In this
>>>> particular instance this is not the case so there is no need to hold
>>>> an extra reference since we directly return.
>>>>
>>>
>>> Looks good. If possible, please also drop other unnecessary bio_get()
>>> in btrfs.
>>
>> You mean everywhere with similar context like in this patch?
>>
>
> Right, there're several places where bio_get() is put before running
> functions but bio_put() is also put immediately without referencing
> bio.
I've already created patches for those and put them through fstests.
Will send them later
>
> thanks,
> -liubo
>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
