On Fri, Jan 12, 2018 at 06:07:02PM -0700, Liu Bo wrote: > Since raid6 recover tries all possible combinations of failed stripes, > > - when raid6 rebuild algorithm is used, i.e. raid6_datap_recov() and > raid6_2data_recov(), it may change the in-memory content of failed > stripes, if such a raid bio is cached, a later raid write rmw or recover > can steal @stripe_pages from it instead of reading from disks, such that > it carries the wrong content to do write rmw or recovery and ends up > with corruption or recovery failures. > > - when raid5 rebuild algorithm is used, i.e. xor, raid bio can be cached > because the only failed stripe which contains @rbio->bio_pages gets > modified, others remain the same so that their in-memory content is > consistent with their on-disk content. > > This adds a check to skip caching rbio if using raid6 recover. > > Signed-off-by: Liu Bo <bo.li....@oracle.com>
Added to 4.16 queue, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
