On 01/27/2018 06:45 AM, Omar Sandoval wrote: > On Sat, Jan 27, 2018 at 01:00:58PM +0800, Qu Wenruo wrote: >> >> >> On 2018年01月27日 03:46, Omar Sandoval wrote: >>> On Fri, Jan 26, 2018 at 08:31:06PM +0100, Goffredo Baroncelli wrote: >>>> On 01/26/2018 07:40 PM, Omar Sandoval wrote: >>>>> From: Omar Sandoval <osan...@fb.com> [...] >> Unfortunately, at least there is also some planned work to bring a >> shared code base between kernel and btrfs-progs, which is also named >> libbtrfs, inspired by libxfs. > > That's right, I forgot about that. There's definitely value in having a > distinction between btrfs_util_ (userspace interfaces) and btrfs_ > (filesystem disk format). > >> And depending on the respect of view, some developer may prefer the >> short btrfs_ prefix for libbtrfs, while other developers/users will >> definitely prefer btrfs_ prefix for libbtrfsutil. >> >> What about shorted prefix like butil_ or btrutil_? > > Those aren't very informative, I think sticking with btrfs_util_ is > fine, it's not that bad to type out.
Let me another chance: what about 'ubtrfs_'... > >> Thanks, >> Qu >> >>> >>> I'll wait a bit for people to bikeshed on the naming before I go and >>> rename everything, but I'm leaning towards the shorter name and >>> appending _fd instead of prepending f_. >>> >>>> 3) regarding the btrfs_util_create_snapshot() function, I think that it >>>> would be useful to add some more information: >>>> a) if used recursive is NOT atomic >>>> b) if used recursive, root capabilities are needed >>>> >>>> The same for the other functions: mark with a 'root required' tag all the >>>> functions which require the root capabilities. >>> >>> That's a great point, I'll document that. >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in >>> the body of a message to majord...@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> > > > > -- gpg @keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it> Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
