On 2018年02月01日 15:08, Su Yue wrote:
>
>
> On 02/01/2018 02:45 PM, Qu Wenruo wrote:
>> Since we're moving tons of codes, it's a good idea to fix all errors and
[snip]
>> }
>> @@ -2500,7 +2507,8 @@ static int repair_extent_data_item(struct
>> btrfs_trans_handle *trans,
>> if (ret)
>> goto out;
>> eb = path.nodes[0];
>> - ei = btrfs_item_ptr(eb, path.slots[0], struct
>> btrfs_extent_item);
>> + ei = btrfs_item_ptr(eb, path.slots[0],
>> + struct btrfs_extent_item);
>> btrfs_set_extent_refs(eb, ei, 0);
>> btrfs_set_extent_generation(eb, ei, generation);
>> @@ -2657,7 +2665,8 @@ static int check_extent_data_item(struct
>> btrfs_root *root,
>> }
>> if (type == BTRFS_EXTENT_DATA_REF_KEY) {
>> ref_root = btrfs_extent_data_ref_root(leaf, dref);
>> - ref_objectid = btrfs_extent_data_ref_objectid(leaf, dref);
>> + ref_objectid = btrfs_extent_data_ref_objectid(leaf,
>> + dref);
>> ref_offset = btrfs_extent_data_ref_offset(leaf, dref);
>> if (ref_objectid == fi_key.objectid &&
>> @@ -2820,8 +2829,8 @@ static int check_block_group_item(struct
>> btrfs_fs_info *fs_info,
>> if (!(bg_flags & BTRFS_BLOCK_GROUP_DATA)) {
>> error(
>> "bad extent[%llu, %llu) type mismatch with chunk",
>> - extent_key.objectid,
>> - extent_key.objectid + extent_key.offset);
>> + extent_key.objectid,
>> + extent_key.objectid + extent_key.offset);
>> err |= CHUNK_TYPE_MISMATCH;
>> }
>> } else if (flags & BTRFS_EXTENT_FLAG_TREE_BLOCK) {
>> @@ -3175,7 +3184,8 @@ static int check_extent_data_backref(struct
>> btrfs_fs_info *fs_info,
>> btrfs_header_owner(leaf) != root_id)
>> goto next;
>> btrfs_item_key_to_cpu(leaf, &key, slot);
>> - if (key.objectid != objectid || key.type !=
>> BTRFS_EXTENT_DATA_KEY)
>> + if (key.objectid != objectid || key.type !=
>> + BTRFS_EXTENT_DATA_KEY)
> if (key.objectid != objectid ||
> key.type != BTRFS_EXTENT_DATA_KEY)
> is more better.
> Other changes are nice.I also thought about that, but that leaves too much space in previous line. Not sure what should be the best practice here. Thank, Qu > > Thanks, > Su
signature.asc
Description: OpenPGP digital signature
