> -----Original Message-----
> From: linux-btrfs-ow...@vger.kernel.org 
> [mailto:linux-btrfs-ow...@vger.kernel.org] On Behalf Of David Sterba
> Sent: Saturday, February 03, 2018 2:47 AM
> To: Gu, Jinxiang/顾 金香 <g...@cn.fujitsu.com>
> Cc: linux-btrfs@vger.kernel.org; dste...@suse.cz; quwenruo.bt...@gmx.com
> Subject: Re: [RFC PATCH v2 0/4] Add support for export testsuits
> 
> On Fri, Feb 02, 2018 at 04:34:01PM +0800, Gu Jinxiang wrote:
> > Achieved:
> > 1. export testsuit by:
> >  $ make EXPORT=/where/you/want/to/generate/tests.tar.gz package
> > relative path and absolute path both be ok.
> > Besides tests itself, fssum and btrfs-corrupt-block will also be
> > included in tests.tar.gz, since misc and fsck tests depend on
> > btrfs-corrupt-block, and misc tests depend on fssum.
> 
> My idea was:
> 
> $ make testuite
> 
> that will build all dependencies, ie. fssum and btrfs-corrupt-block, and 
> create btrfs-progs-tests.tar.gz in the current directory, ie. no need for
> the EXPORT variable.
> 
> The tar command you used would add anything that's under tessts/ but we don't 
> need everything. So I'd expect there's a file that lists all files
> and directories that we want in the testsuite tarball.
> 
> Some sort of identification should be put to the tarball, eg. what git 
> describe says and timestamp of generation.
I will deal with those comments in the next version.

> 
> > 2. after decompress tests.tar.gz, run test by:
> >  $ TEST=`MASK` ./mkfs-tests.sh
> > and, without MASK also be ok.
> > replenish:
> > The directory Structure after decompress tests.tar.gz is:
> >  $ tar -xzvf ./tests.tar.gz
> >  $ ls
> >    tests fssum btrfs-corrupt-block
> 
> The structure could be reduced by one directory level if the contents of 
> tests is moved one directory up. That way all the test driver scritps
> are in the same place as fssum and btrfs-corrupt-block. This would need to be 
> reflected in the test scripts.
I will deal with those comments in the next version.


> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the 
> body of a message to majord...@vger.kernel.org More
> majordomo info at  http://vger.kernel.org/majordomo-info.html
> 



Reply via email to