On Thu, Mar 08, 2018 at 03:26:11PM +0000, Filipe Manana wrote: > On Thu, Mar 8, 2018 at 2:33 PM, David Sterba <dste...@suse.com> wrote: > > The allocation of tree_mod_elem can be delayed after tree_mod_dont_log. > > In case it causes the function to return, the allocation would be > > redundant. Otherwise it could cause unnecessary failure if there's not > > enough memory. > > Nop, the allocation must be made before calling tree_mod_dont_log(), > as that function acquires a write lock. > That's why there's a call to tree_mod_need_log() before the allocation > and a call to tree_mod_dont_log() after (they do the same checks).
Ah right, thanks, it's even documented, dunno why I missed it. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
