On Sat, Feb 10, 2018 at 12:24:41PM +0100, Tomasz Pala wrote: > There is a serious flaw in btrfs subcommands handling. Since all of them > are handled by single 'btrfs' binary, there is no way to create any > protection against accidental data loss for (the only one I've found, > but still DANGEROUS) 'btrfs subvolume delete'.
So, what about this: we can add a global option to add the requested interactivity and commands that are considred dangerous will require the confimation. alias btrfs='btrfs -i' This would expand to 'btrfs -i subvolume delete /subvol' etc. For any command that is not dangerous, the option -i will be accepted but nothing would happen. [...] > (like creating storage pools or managing devices), this should be more > forgiving for any user errors. Since there is no other (obvious) > solution, I propose makeing "subvolume delete" ask for confirmation by > default, unless used with newly introduced option, like -y(--yes). Does it make sense to add an option to override the -i? This would cancel the -i that would be hidden in the alias. This can be generally done by quoting the command, but the option to override -i might fit somebodys usability habits. Either option to 'say yes to all queries' or a simple negation of -i, like -I. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
