On Mon, Mar 26, 2018 at 04:24:47PM +0300, Nikolay Borisov wrote: > >> +# The fs is clean so lowmem shouldn't produce any warnings > >> +run_check "$TOP/btrfs" check --mode=lowmem --readonly "$TEST_DEV" > > > > I understand this is a pinpoint test case for lowmem mode, but for > > lowmem mode test, we set TEST_ENABLE_OVERRIDE and the whole test case > > will use lowmem mode. > > So how exactly is this argument supposed to be used. I tried: > > TEST_ENABLE_OVERRIDE=true TEST=031\* ./fsck-tests.sh - no --lowmem is > appended > > I modify the TEST_ENABLE_OVERRIDE=false to TEST_ENABLE_OVERRIDE=true in > common.local and then just run TEST=031\* ./fsck-tests.sh and it works. > > TEST_ENABLE_OVERRIDE=true TEST_ARGS_CHECK=--mode=lowmem TEST=031\* > ./fsck-tests.sh - this also works?
This is how it's supposed to work via the commandline: - TEST_ENABLE_OVERRIDE is a global switch for any user-defined overrides - TEST_ARGS_CHECK specifies what should be appended to 'check'. > > > I'm not entirely sure what the ci config is but at this point I'm > beginning to worry that if I omit the explicit --mode option this test > might never be run in lowmem mode. CI config == .travis.yml, ie. configuration for the continuous integration, that among others also runs check tests in default and lowmem mode. We don't want mode-specific tests but rather single testcase that can be selectively used with original or lowmem mode. So even if you have a regression test for lowmem, it also must pass in the original mode and therefore there are no switches inside the test script. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
