On Sat, Mar 31, 2018 at 08:57:18AM +0200, Goffredo Baroncelli wrote: > On 03/31/2018 07:03 AM, Zygo Blaxell wrote: > >>> btrfs has no optimization like mdadm write-intent bitmaps; recovery > >>> is always a full-device operation. In theory btrfs could track > >>> modifications at the chunk level but this isn't even specified in the > >>> on-disk format, much less implemented. > >> It could go even further; it would be sufficient to track which > >> *partial* stripes update will be performed before a commit, in one > >> of the btrfs logs. Then in case of a mount of an unclean filesystem, > >> a scrub on these stripes would be sufficient. > > > A scrub cannot fix a raid56 write hole--the data is already lost. > > The damaged stripe updates must be replayed from the log. > > Your statement is correct, but you doesn't consider the COW nature of btrfs. > > The key is that if a data write is interrupted, all the transaction > is interrupted and aborted. And due to the COW nature of btrfs, the > "old state" is restored at the next reboot.
This is not presently true with raid56 and btrfs. RAID56 on btrfs uses RMW operations which are not COW and don't provide any data integrity guarantee. Old data (i.e. data from very old transactions that are not part of the currently written transaction) can be destroyed by this. > What is needed in any case is rebuild of parity to avoid the > "write-hole" bug. And this is needed only for a partial stripe > write. For a full stripe write, due to the fact that the commit is > not flushed, it is not needed the scrub at all. > > Of course for the NODATACOW file this is not entirely true; but I > don't see the gain to switch from the cost of COW to the cost of a log. > > The above sentences are correct (IMHO) if we don't consider a power > failure+device missing case. However in this case even logging the > "new data" would be not sufficient. > > BR > G.Baroncelli > > -- > gpg @keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it> > Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5
signature.asc
Description: PGP signature
