On Wed, Apr 18, 2018 at 09:08:10AM +0800, Qu Wenruo wrote:
> >> dst_rsv = &fs_info->delayed_block_rsv;
> >>
> >> num_bytes = btrfs_calc_trans_metadata_size(fs_info, 1);
> >> +
> >> + /*
> >> + * Here we migrate space rsv from transaction rsv, since have
> >> + * already reserved space when starting a transaction.
> >> + * So no need to reserve qgroup space here.
> >> + */
> >
> > Please format the comments to the full line width.
>
> Right, the already can go previous line without exceeding 80 chars.
>
> But the "So no need to..." line is a new line so it will not take up any
> space of previous line anyway.
You can split the loosely related parts by an empty line, ie.
paragraphs, but I don't tend to like if the new sentence on a new line
when it logically follows the previous one.
> >> @@ -647,7 +657,9 @@ static int btrfs_delayed_inode_reserve_metadata(
> >> "delayed_inode",
> >> btrfs_ino(inode),
> >> num_bytes, 1);
> >> - }
> >> + } else
> >> + btrfs_qgroup_free_meta_prealloc(root,
> >> + fs_info->nodesize);
> >
> > Please don't diverge from the coding style, I'm fixing such issues but,
> > you know.
>
> For this, did you mean the bracket for else branch?
Yes.
if () {
...
} else {
...
}
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
