On 04/24/2018 02:02 PM, Qu Wenruo wrote:
On 2018年04月24日 13:52, Su Yue wrote:
There is no delayed ref in btrfs-progs, so remove related comments.
Indeed.
Delayed ref is only used to speed up extent tree modification with the
cost of code complexity.
Thanks for your explanation :).
For btrfs-progs we don't need to worry about it at all.
So I suggest to remove comments in progs.
Thanks,
Su
Thanks,
Qu
Signed-off-by: Su Yue <suy.f...@cn.fujitsu.com>
---
backref.c | 19 +++----------------
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/backref.c b/backref.c
index 27309e07a1e9..c144dbf060f2 100644
--- a/backref.c
+++ b/backref.c
@@ -155,19 +155,6 @@ static void init_pref_state(struct pref_state *prefstate)
* - if you cannot add the parent or a correct key, then we will look into the
* block later to set a correct key
*
- * delayed refs
- * ============
- * backref type | shared | indirect | shared | indirect
- * information | tree | tree | data | data
- * --------------------+--------+----------+--------+----------
- * parent logical | y | - | - | -
- * key to resolve | - | y | y | y
- * tree block logical | - | - | - | -
- * root for resolving | y | y | y | y
- *
- * - column 1: we've the parent -> done
- * - column 2, 3, 4: we use the key to find the parent
- *
* on disk refs (inline or keyed)
* ==============================
* backref type | shared | indirect | shared | indirect
@@ -735,9 +722,9 @@ static int __add_keyed_refs(struct btrfs_fs_info *fs_info,
}
/*
- * this adds all existing backrefs (inline backrefs, backrefs and delayed
- * refs) for the given bytenr to the refs list, merges duplicates and resolves
- * indirect refs to their parent bytenr.
+ * this adds all existing backrefs (inline backrefs, backrefs for the given
+ * bytenr to the refs list, merges duplicates and resolves indirect refs to
+ * their parent bytenr.
* When roots are found, they're added to the roots list
*
* FIXME some caching might speed things up
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
