On 4/27/18 11:44 AM, David Sterba wrote: > On Thu, Apr 26, 2018 at 11:39:50PM +0300, Nikolay Borisov wrote: >> On 26.04.2018 22:23, je...@suse.com wrote: >>> From: Jeff Mahoney <je...@suse.com> >>> >>> If we fail to allocate memory for a path, don't bother trying to >>> insert the qgroup status item. We haven't done anything yet and it'll >>> fail also. Just print an error and be done with it. >>> >>> Signed-off-by: Jeff Mahoney <je...@suse.com> >> >> nit: So the code is correct however, having the out label there is >> really ugly. What about on path alloc failure just have the print in the >> if branch do goto done? > > Yeah, I don't like jumping to the inner blocks either. I saw this in the > qgroup code so we should clean it up and not add new instances. > > In this case, only the path allocation failure jumps to the out label, > so printing the message and then jump to done makes sense to me. > However, the message would have to be duplicated in the end, and I don't > see a better way without further restructuring the code. >
It doesn't require major surgery. The else can be disconnected. -Jeff -- Jeff Mahoney SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
