On 4/27/18 12:40 PM, David Sterba wrote: > On Fri, Apr 27, 2018 at 12:02:13PM -0400, Jeff Mahoney wrote: >>>> +static void queue_rescan_worker(struct btrfs_fs_info *fs_info) >>>> +{ >>> >>> And this had to be moved upwards as there was earlier use of >>> btrfs_queue_work that matched following the hunk. >> >> Weird. That must be exactly the kind of mismerge artifact that we were >> talking about the other day. In my tree it's in the right spot. > > I've tried current master, upcoming pull request queue (misc-4.17, one > nonc-onflicting patch) and current misc-next. None of them applies the > patch cleanly and the function is still added after the first use, so > this would not compile. > > The result can be found in > https://github.com/kdave/btrfs-devel/commits/ext/jeffm/qgroup-fixes >
Thanks. The "Fixes" is incorrect there. I had the right commit message but not the right commit id. It should be: 8d9eddad1946 (Btrfs: fix qgroup rescan worker initialization) -Jeff -- Jeff Mahoney SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html