On Mon, May 14, 2018 at 4:20 AM, Roman Mamedov <r...@romanrm.net> wrote: > On Mon, 14 May 2018 11:10:34 +0300 > Nikolay Borisov <nbori...@suse.com> wrote: > >> But if we have mounted the fs with FORCE_COMPRESS shouldn't we disregard >> the inode flags, presumably the admin knows what he is doing? > > Please don't. Personally I always assumed chattr +C would prevent both CoW and > compression, and used that as a way to override volume-wide compress-force for > a particular folder. Now that it turns out this wasn't working, the patch > would fix it to behave in line with prior expectations.
"the patch would fix it to behave" might be missing one part. Qu, am I right (best guess, not familiar with btrfs internals enough) this patch will prevent new files and files of size 0 from getting compression with NODATASUM or NODATACOW, but would leave existing compressed files (that shouldn't have been compressed) as they are? After getting an error from btrfs check, presumably, user would need to copy the file(s) to a temporary and copy it back over itself, to get rid of the unwanted compression? -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html