On 20.06.2018 03:38, Qu Wenruo wrote:
> Test misc/029 only works if the test case is executed as root, while for
> sudo usage, it doesn't work as initial mkdir and final cleanup doesn't
> use $SUDO_HELPER.
>
> Add "run_check $SUDO_HELPER" for such cases to allow it works under sudo
> usage.
>
> Signed-off-by: Qu Wenruo <w...@suse.com>
Reviewed-by: Nikolay Borisov <nbori...@suse.com>
Although this seems unrelated to the first patch. I'd advise in this
case to send them as separate patches or if you are going to batch up
multiple fixes add a cover letter saying "just a bunch of random fixes
to xxx" :)
> ---
> tests/misc-tests/029-send-p-different-mountpoints/test.sh | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/misc-tests/029-send-p-different-mountpoints/test.sh
> b/tests/misc-tests/029-send-p-different-mountpoints/test.sh
> index 0b42b772e3d7..90465e1d08fd 100755
> --- a/tests/misc-tests/029-send-p-different-mountpoints/test.sh
> +++ b/tests/misc-tests/029-send-p-different-mountpoints/test.sh
> @@ -14,7 +14,7 @@ prepare_test_dev
> SUBVOL_MNT="$TEST_MNT/subvol"
> TOPLEVEL_MNT="$TEST_MNT/toplevel"
> TEST_MNT="$TOPLEVEL_MNT"
> -mkdir -p "$TOPLEVEL_MNT" "$SUBVOL_MNT"
> +run_check $SUDO_HELPER mkdir -p "$TOPLEVEL_MNT" "$SUBVOL_MNT"
>
> run_check $SUDO_HELPER "$TOP/mkfs.btrfs" -f "$TEST_DEV"
> run_check_mount_test_dev
> @@ -47,5 +47,5 @@ run_mustfail_stdout "send -p on 2 mount points" \
> run_check_umount_test_dev "$SUBVOL_MNT"
> run_check_umount_test_dev "$TOPLEVEL_MNT"
>
> -rmdir "$SUBVOL_MNT"
> -rmdir "$TOPLEVEL_MNT"
> +run_check $SUDO_HELPER rmdir "$SUBVOL_MNT"
> +run_check $SUDO_HELPER rmdir "$TOPLEVEL_MNT"
>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
