On Tue, Jul 03, 2018 at 08:58:05PM +0200, Martin Steigerwald wrote: > Nikolay Borisov - 03.07.18, 11:08: > > On 3.07.2018 11:47, Qu Wenruo wrote: > > > On 2018年07月03日 16:33, Nikolay Borisov wrote: > > >> On 3.07.2018 11:08, Qu Wenruo wrote: > > >>> Reported in https://bugzilla.kernel.org/show_bug.cgi?id=199837, if > > >>> a > > >>> crafted btrfs with incorrect chunk<->block group mapping, it could > > >>> leads to a lot of unexpected behavior. > > >>> > > >>> Although the crafted image can be catched by block group item > > >>> checker > > >>> added in "[PATCH] btrfs: tree-checker: Verify block_group_item", > > >>> if one crafted a valid enough block group item which can pass > > >>> above check but still mismatch with existing chunk, it could > > >>> cause a lot of undefined behavior. > > >>> > > >>> This patch will add extra block group -> chunk mapping check, to > > >>> ensure we have a completely matching (start, len, flags) chunk > > >>> for each block group at mount time. > > >>> > > >>> Reported-by: Xu Wen <wen...@gatech.edu> > > >>> Signed-off-by: Qu Wenruo <w...@suse.com> > > >>> --- > > >>> changelog: > > >>> > > >>> v2: > > >>> Add better error message for each mismatch case. > > >>> Rename function name, to co-operate with later patch. > > >>> Add flags mismatch check. > > >>> > > >>> --- > > >> > > >> It's getting really hard to keep track of the various validation > > >> patches you sent with multiple versions + new checks. Please batch > > >> everything in a topic series i.e "Making checks stricter" or some > > >> such and send everything again nicely packed, otherwise the risk > > >> of mis-merging is increased. > > > > > > Indeed, I'll send the branch and push it to github. > > > > > >> I now see that Gu Jinxiang from fujitsu also started sending > > >> validation fixes. > > > > > > No need to worry, that will be the only patch related to that thread > > > of bugzilla from Fujitsu. > > > As all the other cases can be addressed by my patches, sorry Fujitsu > > > guys :)> > > >> Also for evry patch which fixes a specific issue from one of the > > >> reported on bugzilla.kernel.org just use the Link: tag to point to > > >> the original report on bugzilla that will make it easier to relate > > >> the fixes to the original report. > > > > > > Never heard of "Link:" tag. > > > Maybe it's a good idea to added it to "submitting-patches.rst"? > > > > I guess it's not officially documented but if you do git log --grep > > "Link:" you'd see quite a lot of patches actually have a Link pointing > > to the original thread if it has sparked some pertinent discussion. > > In this case those patches are a direct result of a bugzilla > > bugreport so having a Link: tag makes sense. > > For Bugzilla reports I saw something like > > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=43511 > > in a patch I was Cc´d to. > > Of course that does only apply if the patch in question fixes the > reported bug.
The tag 'Fixes:' already has some meaning and should point to the commit id and subject of a patch that it fixes. The stable team and its bots/filters recognize this flag and this helps maintainers to forward patches to the stable trees. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
