On Thu, Jul 12, 2018 at 02:56:55PM +0800, Qu Wenruo wrote:
>
>
> On 2018年07月12日 14:27, Nikolay Borisov wrote:
> >
> >
> > On 12.07.2018 09:19, Qu Wenruo wrote:
> >> Introduce a new macro based compile time check for ioctl structures.
> >>
> >> The new macro is BTRFS_ASSERT_SIZE(), which is mostly copied from
> >> VMMDEV_ASSERT_SIZE().
> >>
> >> Such check is only added to structure pended to power of 2.
> >> And exposed one structure, btrfs_ioctl_get_dev_stats() is not aligned
> >> well.
> >> The misalign is introduced by commit b27f7c0c150f ("btrfs: join DEV_STATS
> >> ioctls to one").
> >
> > So what's the negative effect if a structure is not aligned to a power of 2?
>
> No real negative effect, until one day one may find the comment is not
> correct.
So the comment needs to be fixed.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
