On 2018年07月18日 14:45, Lu Fengqi wrote: > The transaction handler can provide fs_info, so we can fetch fs_info or > quota_root(indirectly) from trans. Just remove the redundant parameter > from qgroup functions. > > No functional change.
The whole serious looks pretty good. Although for some call sites, we have extra check on NULL trans and return -EINVAL (should be ASSERT though). Maybe it's a good time to remove that paranoid check? Thanks, Qu > > Lu Fengqi (19): > btrfs: qgroup: Drop quota_root parameter from add_qgroup_relation_item > btrfs: qgroup: Drop quota_root parameter from del_qgroup_relation_item > btrfs: qgroup: Drop quota_root parameter from del_qgroup_item > btrfs: qgroup: Drop root parameter from update_qgroup_limit_item > btrfs: qgroup: Drop root parameter from update_qgroup_info_item > btrfs: qgroup: Drop quota_root and fs_info parameters from > update_qgroup_status_item > btrfs: qgroup: Drop fs_info parameter from btrfs_add_qgroup_relation > btrfs: qgroup: Drop fs_info parameter from __del_qgroup_relation > btrfs: qgroup: Drop fs_info parameter from btrfs_del_qgroup_relation > btrfs: qgroup: Drop fs_info parameter from btrfs_create_qgroup > btrfs: qgroup: Drop fs_info parameter from btrfs_remove_qgroup > btrfs: qgroup: Drop fs_info parameter from btrfs_limit_qgroup > btrfs: qgroup: Drop fs_info parameter from btrfs_qgroup_trace_extent > btrfs: qgroup: Drop fs_info parameter from > btrfs_qgroup_trace_leaf_items > btrfs: qgroup: Drop root parameter from btrfs_qgroup_trace_subtree > btrfs: qgroup: Drop fs_info parameter from btrfs_qgroup_account_extent > btrfs: qgroup: Drop fs_info parameter from btrfs_run_qgroups > btrfs: qgroup: Drop fs_info parameter from btrfs_qgroup_inherit > btrfs: qgroup: Drop fs_info parameter from qgroup_rescan_leaf > > fs/btrfs/extent-tree.c | 4 +- > fs/btrfs/ioctl.c | 18 ++-- > fs/btrfs/qgroup.c | 163 +++++++++++++++++----------------- > fs/btrfs/qgroup.h | 40 ++++----- > fs/btrfs/relocation.c | 5 +- > fs/btrfs/tests/qgroup-tests.c | 24 ++--- > fs/btrfs/transaction.c | 5 +- > fs/btrfs/tree-log.c | 2 +- > 8 files changed, 123 insertions(+), 138 deletions(-) >
signature.asc
Description: OpenPGP digital signature
