On Wed, Jul 04, 2018 at 10:24:51AM +0300, Nikolay Borisov wrote:
> Current version of the page unlocking code was added in
> 727011e07cbd ("Btrfs: allow metadata blocks larger than the page size")
> but even in this commit that particular flag was never used per-se. In
> fact, btrfs only uses PageChecked for data pages to identify pages
> which have been dirtied but don't have ORDERED bit set. For more
> information see 247e743cbe6e ("Btrfs: Use async helpers to deal with
> pages that have been improperly dirtied"). However, this doesn't apply
> to extent buffer pages. The important bit here is that the pages are
> unlocked AFTER the extent buffer has been properly recorded in the
> radix tree to avoid races with btree_releasepage. Let's exploit this
> fact and simplify the page unlocking sequence by unlocking the pages
> in-order and removing the redundant PageChecked flag setting/clearing.
>
> Signed-off-by: Nikolay Borisov <nbori...@suse.com>
Reviewed-by: David Sterba <dste...@suse.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
