On 2018-08-21 09:43, David Howells wrote:
Qu Wenruo <quwenruo.bt...@gmx.com> wrote:
But to be more clear, NOSSD shouldn't be a special case.
In fact currently NOSSD only affects whether we will output the message
"enabling ssd optimization", no real effect if I didn't miss anything.
That's not quite true. In:
if (!btrfs_test_opt(fs_info, NOSSD) &&
!fs_info->fs_devices->rotating) {
btrfs_set_and_info(fs_info, SSD, "enabling ssd optimizations");
}
the call to btrfs_set_and_info() will turn on SSD.
What this seems to me is that, normally, SSD will be turned on automatically
unless at least one of the devices is a rotating medium - but this appears to
be explicitly suppressed by the NOSSD option.
That's my understanding too (though I may be wrong, I'm not an expert on C).
If this _isn't_ what's happening, then it needs to be changed so it is,
that's what the documentation has pretty much always said, and is
therefore how people expect it to work (also, it needs to work because
there needs to be an option other than poking around at sysfs attributes
to disable this on non-rotational media where it's not want4ed).
