On Mon, Sep 10, 2018 at 07:57:20PM +0200, David Sterba wrote:
> On Mon, Sep 03, 2018 at 01:02:57PM +0300, Nikolay Borisov wrote:
> > Add a test which ensures the kernel returns the correct error value
> > when missing device removal is requested. This test verifies that kernel
> > refactoring didn't broken the return value.
> >
> > Signed-off-by: Nikolay Borisov <nbori...@suse.com>
> > ---
> > tests/misc-tests/011-delete-missing-device/test.sh | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/tests/misc-tests/011-delete-missing-device/test.sh
> > b/tests/misc-tests/011-delete-missing-device/test.sh
> > index 4c976421c091..b799a25c201d 100755
> > --- a/tests/misc-tests/011-delete-missing-device/test.sh
> > +++ b/tests/misc-tests/011-delete-missing-device/test.sh
> > @@ -44,6 +44,21 @@ test_delete_missing()
> > run_check_umount_test_dev
> > }
> >
> > +test_missing_error()
> > +{
> > + run_check $SUDO_HELPER "$TOP/mkfs.btrfs" -f "$TEST_DEV"
> > + run_check_mount_test_dev
> > + local out
> > + out=$(run_mustfail_stdout "Unexpected success" \
>
> Which would become:
>
> unexpected success: Unexpected success
>
> You'd win the error message of the year :) The text is supposed to be
> more specific what was not expected, eg. "missing device removed".
Updated and applied, thanks.
