On 09/24/2018 10:08 AM, Nikolay Borisov wrote: >> >> The bugs are all related to repeated kernel code all over the place >> containing a lot of if statements dealing with different kind of >> allocation profiles and their exceptions. What I ended up doing is >> making a few helper functions instead, see the commit "Add volumes.py, >> handling device / chunk logic". It would probably be nice to do the same >> in the kernel code, which would also solve the mentioned bugs and >> prevent new similar ones from happening. > > Would you care to report each bug separately so they can be triaged and > fixed?
In case of the RAID10 5GiB thing I think I was mixing up things. When doing mkfs you end up with a RAID10 chunk of 5GiB (dunno why, didn't research), when mounting and pointing balance at it, I get a 10GiB for it back, so that's ok. For the DUP thing, I sent an explanation ("DUP dev_extent might overlap something next to it"), which doesn't seem to attract much attention yet. I'm preparing a pile of patches to volumes.[ch] to fix this, clean up things that I ran into and make the logic a bit less convoluted. -- Hans van Kranenburg