On 20.11.18 г. 11:07 ч., Qu Wenruo wrote:
>
>
> On 2018/11/20 下午4:51, Nikolay Borisov wrote:
<snip>
>> I'm beginning to wonder, should we document
>> btrfs_add_delayed_data_ref/btrfs_add_tree_ref arguments separate for
>> each function, or should only the differences be documented - in this
>> case the newly added root parameter. The rest of the arguments are being
>> documented at init_delayed_ref_common.
>
> You won't be happy with my later plan, it will add new parameter for
> btrfs_add_delayed_tree_ref(), and it may not be @root, but some bool.
You are right, but I'm starting to think that the interface of adding
those references is wrong because we shouldn't really need adding more
and more arguments. All of this feels like piling hack on top of hack
for some legacy infrastructure which no one bothers fixing from a
high-level.
>
> So I think we may need to document at least the difference.
>
> Thanks,
> Qu
>
>>
<snip>
