Re: [PATCH 3/3] btrfs: remove redundant nowait check for buffered_write

[Nikolay Borisov]

On 28.11.18 г. 5:23 ч., Lu Fengqi wrote:
> The generic_write_checks will check the combination of IOCB_NOWAIT and
> !IOCB_DIRECT.

True, however btrfs will return ENOSUPP whereas the generic code returns
EINVAL. I guess this is not a big deal and it's likely generic code is
correct, so:

Reviewed-by: Nikolay Borisov <nbori...@suse.com>

> 
> Signed-off-by: Lu Fengqi <lufq.f...@cn.fujitsu.com>
> ---
>  fs/btrfs/file.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
> index 3835bb8c146d..190db9a685a2 100644
> --- a/fs/btrfs/file.c
> +++ b/fs/btrfs/file.c
> @@ -1889,10 +1889,6 @@ static ssize_t btrfs_file_write_iter(struct kiocb 
> *iocb,
>       loff_t oldsize;
>       int clean_page = 0;
>  
> -     if (!(iocb->ki_flags & IOCB_DIRECT) &&
> -         (iocb->ki_flags & IOCB_NOWAIT))
> -             return -EOPNOTSUPP;
> -
>       if (!inode_trylock(inode)) {
>               if (iocb->ki_flags & IOCB_NOWAIT)
>                       return -EAGAIN;
>