On Wed, Jan 23, 2019 at 03:15:11PM +0800, Qu Wenruo wrote: > - A lot of coding style fixes: > * naming change from "file"/"subv" to "subvol" > * {} for any else if branch > * avoid err/ret confusion by introducing "tmp_ret" > * proper errno for non-uptodate extent buffer > * struct member re-ordering to avoid unnecessary padding > * avoid single letter variable name > * less redundant emphasizing > * move certain devel-only warning under CONFIG_BTRFS_DEBUG > * replace cool-sounding 'hack' with 'optimization' > * remove unnecessary inline prefix for btrfs_qgroup_init_swapped_blocks > * keep an empty line before #endif
Thank you, reading through the patches was now much smoother experience for me. I'll let it pass fstests and merge it to misc-next, as there are more patches and patchsets depending on it so we can give it wider testing. The slow metadata balance patch has been posted, the qgroup deadlock still needs to be resolved. If you have ideas or pending cleanups in the qgroup code then it's fine to send them until rc5. I hope the main functional changes are about to be merged, small fixups or additions should be within the scope of testing.