On 2019/3/21 下午9:19, David Sterba wrote: > On Wed, Mar 20, 2019 at 02:27:45PM +0800, Qu Wenruo wrote: >> Do proper cleanup if we hit any error in extent_write_locked_range(), >> and check the return value of flush_write_bio(). > > Yes that's what the code does, but the changelog should explain why this > is correct. Same for "btrfs: extent_io: Handle error better in > extent_writepages()". You do that in other patches, why not in this one > too?
My bad, I thought the patch implementing end_write_bio() explains why the cleanup function is doing the same work as previous flush_write_bio(), but skipping the bio submitting. So I skipped the reason why calling end_write_bio() here is enough for the error case. > If the reason is same for several patches, then copy it, eg. btrfs: > "extent_io: Handle errors better in btree_write_cache_pages()" is ok. > > But don't resend, I'll fix it here as I made some other fixups to > changelogs and am finishing the whole series. Thank you for the effort and sorry for the inconvenience. Thanks, Qu >
signature.asc
Description: OpenPGP digital signature
