On Wed, Apr 03, 2019 at 10:15:27PM +0800, Qu Wenruo wrote: > > > On 2019/4/3 下午10:13, David Sterba wrote: > > On Wed, Apr 03, 2019 at 07:59:18PM +0800, Qu Wenruo wrote: > >> Commit "btrfs: Do mandatory tree block check before submitting bio" is > >> designed to check leaves contents, just as read time check. > >> > >> However due to the confusing parameter list, "false" is passed to where > >> it is supposed to be "true". > > > > And this seems to invalidate all testing since false->true will do > > additional expensive checks. > > That's the case. > > However with the next patch, btrfs_check_leaf_full() is less expensive. > Just 3~5 times expensive as csum_tree_block(), reduced from 20 times. > > My full fstests run is coming to the end and so far no regression. > > > I thought I'd fold the fix to the original > > patch but in this case it'd be the wrong thing to do due to the visible > > effects of the change. > > If that's the case, I'd add new Fixes: tag, but that can only happen > after write time patch get merged upstream.
Fixes: to development patches should raise an alert that something's wrong.
