On Fri, May 10, 2019 at 03:30:36PM +0300, Nikolay Borisov wrote:
[...]
> 
> nit: Might be a good idea to turn that into an enum for self-documenting
> purposes. Perhaps in a different patch.

Thought about this as well, but I thought I remembered a patch series from
David where he turned everything not being an on-disk format to enums.

This discuraged me from actually doing the switch. I'd be more than happy if I
could just use an enum.

Byte,
        Johannes
-- 
Johannes Thumshirn                            SUSE Labs Filesystems
jthumsh...@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Reply via email to