On Mon, Jun 03, 2019 at 08:30:22PM +0200, David Sterba wrote: > On Mon, Jun 03, 2019 at 04:58:46PM +0200, Johannes Thumshirn wrote: > > This patchset add support for adding new checksum types in BTRFS. > > V4 looks good to me, with a few minor fixups added to topic branch, > including the sha256 patch. As noted this may not be merged and now > servers for the testing purposes.
Thanks \o/ [...] > We'll need that one, briefly checking the progs souces, the same > cleanups will be needed there too. Yep, I've already started doing the progs side as well. > > > b) David requested to have three hash algorithms, where 1 is crc32c, one > > cryptographically secure and one in between. > > Let me summarize the current satus: > > for strong hash we have SHA256 and BLAKE2. For the fast hash xxhash and > murmur3 have been suggested. Let me add XXH3 and xxh128 for now (they're > not finalized yet). I know there's a tendency to not trust FIPS but please let's not completely rule out FIPS approved algorithms (be it SHA-2 or SHA-3) because we will get asked to include one sooner or later. Byte, Johannes -- Johannes Thumshirn SUSE Labs Filesystems jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850