On Tue, Jun 25, 2019 at 08:54:30AM -0400, Josef Bacik wrote: > On Tue, Jun 25, 2019 at 01:58:43PM +0200, David Sterba wrote: > > On Tue, Jun 18, 2019 at 04:09:19PM -0400, Josef Bacik wrote: > > > --- /dev/null > > > +++ b/fs/btrfs/space-info.c > > > @@ -0,0 +1,177 @@ > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > +/* > > > + * Copyright (C) 2019 Facebook. All rights reserved. > > > + */ > > > > How does the copyright claim work here? You're just moving code from a > > file (extent-tree.c) that has > > > > "Copyright (C) 2007 Oracle. All rights reserved." > > > > Adding company copyright to new files that implement something > > completely new seems to be fine and I don't object against adding it, > > though personally I think it's pointless to add the copyrights when > > there's the Signed-off-by mechanism and full and immutable history of > > changes tracked in git and newly the SPDX tag to disperse any confusion > > about licensing of individual files. > > > > Yeah I agree, fix it however you like, the signed-off chain seems to be what's > important. Thanks,
Thanks, I've summarized that on wiki so we can point to that when needed. https://btrfs.wiki.kernel.org/index.php/Developer%27s_FAQ#Copyright_notices_in_files
