> On 15 Jul 2019, at 11:09 PM, Nikolay Borisov <nbori...@suse.com> wrote:
>
>
>
> On 15.07.19 г. 17:42 ч., Anand Jain wrote:
>> To help debug device scan issues, add verbose option to btrfs device scan.
>>
>> Signed-off-by: Anand Jain <anand.j...@oracle.com>
>
> I fail to see what this patch helps for.
>
To know what are the devices path scanned.
> We get the path in case of errors,
No. We get the devices path when we use -v option and the cli [1] can be
success / fail.
[1] 'btrfs device scan -v'
> in case of success what good could the path be ?
>
>> ---
>> cmds/device.c | 8 ++++++--
>> cmds/filesystem.c | 2 +-
>> common/device-scan.c | 4 +++-
>> common/device-scan.h | 2 +-
>> common/utils.c | 2 +-
>> disk-io.c | 2 +-
>> 6 files changed, 13 insertions(+), 7 deletions(-)
>>
>> diff --git a/cmds/device.c b/cmds/device.c
>> index 24158308a41b..2fa13e61f806 100644
>> --- a/cmds/device.c
>> +++ b/cmds/device.c
>> @@ -313,6 +313,7 @@ static int cmd_device_scan(const struct cmd_struct *cmd,
>> int argc, char **argv)
>> int all = 0;
>> int ret = 0;
>> int forget = 0;
>> + int verbose = 0;
>
> nit: make it a bool.
yep. Will do.
Thanks, Anand
