On Sat, Aug 17, 2019 at 11:14:34PM +0000, Vladimir Panteleev wrote: > Move the full-balance warning to before the fork, so that the user can > see and react to it. > > Notes on test: > > - Don't use grep -q, as it causes a SIGPIPE during the countdown, and > the balance thus doesn't start. > > - The "balance cancel" is superfluous as the last command, but it > provides some idempotence and allows adding more tests below it. > > Fixes: https://github.com/kdave/btrfs-progs/issues/168 > > Signed-off-by: Vladimir Panteleev <g...@vladimir.panteleev.md>
Applied, thanks. The issues can be referenced as Issue: #168 > --- a/tests/cli-tests/002-balance-full-no-filters/test.sh > +++ b/tests/cli-tests/002-balance-full-no-filters/test.sh > @@ -18,4 +18,9 @@ run_check $SUDO_HELPER "$TOP/btrfs" balance start > "$TEST_MNT" > run_check $SUDO_HELPER "$TOP/btrfs" balance --full-balance "$TEST_MNT" > run_check $SUDO_HELPER "$TOP/btrfs" balance "$TEST_MNT" > > +run_check_stdout $SUDO_HELPER "$TOP/btrfs" balance start --background > "$TEST_MNT" | > + grep -F "Full balance without filters requested." || This needs -q, otherwise the text appears in the output of make. Fixed.
