On Mon, Aug 26, 2019 at 06:38:13PM +0300, Nikolay Borisov wrote: > nit: I'd name this commit "Add xxhash64 to supported checksum hashes" > > Personally, I interpret 'use <some hash> for checksumming' as if you are > modifying code to use that hash. But in fact you are not, at least not > in that patch.
It could be percieved as nitpicking, but this kind of feedback is a check that the author's intentions are understood by someone else. Some subtleties or nuances can be missed by authors and this is maybe inevitable when one spends significant time on the code or changelog. The fresh look and first impression is not possible anymore. But this is how patches are read when found git log. In this case I agree with you and the use use of 'use' is a bit misleading, suggesting that xxhash is now default.
