On 9/3/19 8:06 PM, David Sterba wrote:
On Mon, Sep 02, 2019 at 06:22:30PM +0200, David Sterba wrote:
On Mon, Sep 02, 2019 at 04:01:56PM +0800, Anand Jain wrote:
David,
I don't see this patch is integrated. Can you please integrated this
patch thanks.
I don't know why but the patch got lost somewhere, adding to devel
again.
Not lost, but dropped, misc-tests/021 fails. So dropped again, please
fix it and test before posting again. Thanks.
I have unit tested this patch successfully, misc-tests/021 is a false
positive failure. Because it assumes btrfs-image collects the data and
attempts to read the file on the restored image, and rightly ends up
with IO error.
-------
md5sum: /Volumes/ws/btrfs-progs/tests//mnt/foobar: Input/output error
failed: md5sum /Volumes/ws/btrfs-progs/tests//mnt/foobar
------
The test case is successful so far because the images is restored on the
same loop device, and unfortunately stale data on the loop device
matched and helped read from the restored image to succeed.
Tweak the test case a little as below and it fails even without this patch.
----------------------
diff --git a/tests/misc-tests/021-image-multi-devices/test.sh
b/tests/misc-tests/021-image-multi-devices/test.sh
index b1013b5d2596..05f4146b6007 100755
--- a/tests/misc-tests/021-image-multi-devices/test.sh
+++ b/tests/misc-tests/021-image-multi-devices/test.sh
@@ -17,7 +17,7 @@ loop2=${loopdevs[2]}
# Create the test file system.
-run_check $SUDO_HELPER "$TOP/mkfs.btrfs" -f "$loop1" "$loop2"
+run_check $SUDO_HELPER "$TOP/mkfs.btrfs" -f "$loop2" "$loop1"
run_check $SUDO_HELPER mount "$loop1" "$TEST_MNT"
run_check $SUDO_HELPER dd bs=1M count=1 if=/dev/zero of="$TEST_MNT/foobar"
orig_md5=$(run_check_stdout md5sum "$TEST_MNT/foobar" | cut -d ' ' -f 1)
----------------------
This patch is good to integrate.
Thanks, Anand
