Hi. First, thanks for finding&fixing this :-)
On Thu, 2019-09-12 at 08:50 +0100, Filipe Manana wrote: > 1) either a hang when committing a transaction, reported by several > users recently and hit it myself too twice when running fstests (test > case generic/475 and generic/561) after I upgradaded my development > branch from a 5.1.x kernel to a 5.3-rcX kernel. If this happens you > risk no corruption, still the hang is very inconvenient of course, as > you have to reboot. Okay inconvenient, but not so bad if there is no corruption risk. > 2) writeback for some btree nodes may never be started and we end up > committing a transaction without noticing that. This is really > serious > and that will lead to the "parent transid verify failed on ..." > messages. As some people have already pointed out, it will be infeasible for many end users to downgrade (no security updates) or manually patch (well, end-users). Can you elaborate under which circumstances this problem occurs, whether there are any intermediate workarounds, and whether it's always noticed (i.e. no silence corruption)? Thanks, Chris.