On Fri, Sep 13, 2019 at 04:46:09PM +0100, Filipe Manana wrote:
> On Fri, Sep 13, 2019 at 2:54 PM Dennis Zhou <den...@kernel.org> wrote:
> >
> > Before, if a eb failed to write out, we would end up triggering a
> > BUG_ON(). As of f4340622e0226 ("btrfs: extent_io: Move the BUG_ON() in
> > flush_write_bio() one level up"), we no longer BUG_ON(), so we should
> > make life consistent and add back the unwritten bytes to
> > dirty_metadata_bytes.
> >
> > Signed-off-by: Dennis Zhou <den...@kernel.org>
> > Cc: Filipe Manana <fdman...@kernel.org>
>
> Looks good.
> However I find the subject very confusing and misleading.
>
> "extent_io read eb to dirty_metadata_bytes on ioerr"
>
> That gives the idea of reading the eb (like from disk? or its content,
> reading from its pages?), and the "to dirty_metadata_bytes" also find
> it confusing.
> Something like:
>
> "btrfs: adjust dirty_metadata_bytes after writeback failure of extent buffer"
>
> would make it clear and not confusing IMHO.
> Perhaps it's something David can change when he picks the patch
> (either to that or some other more clear subject).
That's perfectly fine to suggest updates to subject or changelogs in
case you find them worth an improvement. Patch updated and queued for,
thanks.
