---- 在 星期一, 2019-10-07 23:44:45 David Sterba <dste...@suse.cz> 撰写 ---- > On Sat, Oct 05, 2019 at 01:17:34PM +0800, Chengguang Xu wrote: > > hash_init() is not necessary in btrfs_props_init(), > > so remove it. > > The part that explains why it's not necessary is missing in the > changelo. And looking what hash_init and plain DEFINE_HASHTABLE does I > don't think that removing hash_init is safe or making the code more > clear. Sorry for pool explanation in change log.
Look into the code, DEFINE_HASHTABLE has already included initialization code in it and I think this is the main difference compare to DECLARE_HASHTABLE which still needs hash_init. Thanks, Chengguang
