On Tue, Oct 08, 2019 at 08:47:14AM +0200, Johannes Thumshirn wrote: > On 07/10/2019 17:46, David Sterba wrote: > [...] > >> nit: This function is used only once and the ARRAY_SIZE() macro is > >> descriptive enough, why not just remove it and opencoude the call to > >> array_size > > > > Agreed, ARRAY_SIZE in loops is fine, it's a compile-time constant. > > Nope, btrfs_csums[] is defined in ctree.c, so I can't get the size of > this array outside of ctree.c. And it was moved to ctree.c from ctree.h > on request by David.
Ohh, right you are of course.