On Tue, Oct 15, 2019 at 02:17:55PM +0200, David Sterba wrote: > On Mon, Oct 07, 2019 at 04:17:34PM -0400, Dennis Zhou wrote: > > @@ -2165,6 +2173,7 @@ static bool try_merge_free_space(struct > > btrfs_free_space_ctl *ctl, > > bool merged = false; > > u64 offset = info->offset; > > u64 bytes = info->bytes; > > + bool is_trimmed = btrfs_free_space_trimmed(info); > > Please add a const in such cases. I've been doing that in other patches > but as more iterations are expected, let's have it there from the > beginning. >
Done. > > --- a/fs/btrfs/free-space-cache.h > > +++ b/fs/btrfs/free-space-cache.h > > @@ -6,6 +6,8 @@ > > #ifndef BTRFS_FREE_SPACE_CACHE_H > > #define BTRFS_FREE_SPACE_CACHE_H > > > > +#define BTRFS_FSC_TRIMMED (1UL << 0) > > Please add a comment I've switched this to an enum and added a comment above it. Thanks, Dennis
