On Mon, Nov 30, 2020 at 04:01:38PM -0800, Boris Burkov wrote: > On Mon, Nov 23, 2020 at 05:57:04PM +0100, David Sterba wrote: > > On Wed, Nov 18, 2020 at 03:06:16PM -0800, Boris Burkov wrote: > > > +/* > > > + * Mounting logic specific to read-write file systems. Shared by > > > open_ctree > > > + * and btrfs_remount when remounting from read-only to read-write. > > > + */ > > > +int btrfs_mount_rw(struct btrfs_fs_info *fs_info) > > > > The function could be named better, to reflect that it's starting some > > operations prior to the rw mount. As its now it would read as "mount the > > filesystem as read-write", we already have 'btrfs_mount' as callback for > > mount. > > > > As this is a cosmetic fix it's not blocking the patchset but I'd like to > > have that fixed for the final version. I don't have a suggestion for > > now. > > I agree, the name implies a function which does a rw mount end to end. > > Some alternative ideas: > btrfs_prepare_rw_mount > btrfs_setup_rw_mount > btrfs_handle_rw_mount > btrfs_process_rw_mount > > I think I personally like 'prepare' the most out of those.
I had not noticed your reply when I committed the patch, the function is btrfs_start_pre_rw_mount. btrfs_prepare_rw_mount would be also good, we can rename it eventually if it needed.
