On Sun, Jan 24, 2021 at 08:35:27AM +0800, Qu Wenruo wrote: > On 2021/1/24 上午3:13, David Sterba wrote: > > On Thu, Jan 21, 2021 at 02:51:46PM +0800, Qu Wenruo wrote: > >> On 2021/1/21 下午2:32, Qu Wenruo wrote: > >>> On 2021/1/20 上午5:41, Josef Bacik wrote: > >>>> On 1/16/21 2:15 AM, Qu Wenruo wrote: > >> To be more clear, we call extent_clear_unlock_delalloc() with > >> locked_page == NULL, to allow __process_pages_contig() to unlock the > >> locked page (while the locked page isn't locked by > >> __process_pages_contig()). > >> > >> For subpage data, we need writers accounting for subpage, but that > >> accounting only happens in __process_pages_contig(), thus we don't want > >> pages without the accounting to be unlocked by __process_pages_contig(). > >> > >> I can do extra page unlock/clear_dirty/end_writeback just for that > >> exception, but it would definitely needs more comments. > > > > This is patch 1 and other depend on the changed behaviour so if it's > > just updated changelog and comments, and Josef is ok with the result, I > > can take it but otherwise this could delay the series once the rest is > > reworked. > > > In fact there aren't many changes depending on it, until we hit RW support. > > Thus I can move this patch to RW series, so that we can fully focus on > RO support.
That's a good option. > The patchset will be delayed for a while (ETA in week 04), mostly due to > the change in how we handle metadata ref count (other than just > under_alloc). > > Would this be OK for you? Yes that OK, thanks.
