On Wed, Jan 27, 2021 at 06:52:04PM +0800, Qu Wenruo wrote: > On 2021/1/27 下午6:44, Filipe Manana wrote: > > On Wed, Jan 27, 2021 at 8:29 AM Qu Wenruo <w...@suse.com> wrote: > >> As the first iteration will find OE 1, which doesn't cover the full > >> page, thus after cleanup code, we need to retry again. > >> But again label will reset start to page_start, and we got OE 1 again, > >> which causes double account on OE1, and cause OE1's byte_left to > >> underflow. > >> > >> The only good news is, this problem can only happen for subpage case, as > >> for regular sectorsize == PAGE_SIZE case, we will always find a OE ends > >> at or after page end, thus no way to trigger the problem. > >> > >> This patch will move the again label after start = page_start, to fix > >> the bug. > >> This is just a quick fix, which is easy to backport. > > > > Hum? Why does it need to be backported? > > There are no kernel releases that support subpage sector size yet and > > this does not affect the case where sector size is the same as the > > page size. > > > Hmmm, right, there is no need to backport. > > Hopes David can remove that line when merging.
Yes, I've dropped the 'backport' line and slightly changed the wording so it sounds like it's preparatory patch.
