We will record the fs root or the reloc root in the trans in
select_reloc_root.  These will actually return errors in the following
patches, so check their return value here and return it up the stack.

Reviewed-by: Qu Wenruo <w...@suse.com>
Signed-off-by: Josef Bacik <jo...@toxicpanda.com>
---
 fs/btrfs/relocation.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
index 0f2ecf61696e..b70a666612a7 100644
--- a/fs/btrfs/relocation.c
+++ b/fs/btrfs/relocation.c
@@ -1988,6 +1988,7 @@ struct btrfs_root *select_reloc_root(struct 
btrfs_trans_handle *trans,
        struct btrfs_backref_node *next;
        struct btrfs_root *root;
        int index = 0;
+       int ret;
 
        next = node;
        while (1) {
@@ -2023,11 +2024,15 @@ struct btrfs_root *select_reloc_root(struct 
btrfs_trans_handle *trans,
                }
 
                if (root->root_key.objectid == BTRFS_TREE_RELOC_OBJECTID) {
-                       record_reloc_root_in_trans(trans, root);
+                       ret = record_reloc_root_in_trans(trans, root);
+                       if (ret)
+                               return ERR_PTR(ret);
                        break;
                }
 
-               btrfs_record_root_in_trans(trans, root);
+               ret = btrfs_record_root_in_trans(trans, root);
+               if (ret)
+                       return ERR_PTR(ret);
                root = root->reloc_root;
 
                if (next->new_bytenr != root->node->start) {
-- 
2.26.2

Reply via email to